From ae03a427fd436abb9c71d525122301c17fdc18cc Mon Sep 17 00:00:00 2001 From: Michael Bestas Date: Thu, 13 Jun 2024 20:24:53 +0300 Subject: [PATCH] sm7325-common: gps: data-items: Fix snprintf usage Fixes: gps/core/data-items/DataItemConcreteTypes.cpp:465:9: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 20 [-Werror,-Wfortify-source] 465 | snprintf(t, sizeof(t), "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], | ^ gps/core/data-items/DataItemConcreteTypes.cpp:514:9: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 20 [-Werror,-Wfortify-source] 514 | snprintf(t, sizeof(t), "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], | ^ 2 errors generated. Change-Id: I37188e7497f7ade97648fb41e2becd73f6b559a9 --- gps/core/data-items/DataItemConcreteTypes.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gps/core/data-items/DataItemConcreteTypes.cpp b/gps/core/data-items/DataItemConcreteTypes.cpp index 3142ffe..6ea3905 100644 --- a/gps/core/data-items/DataItemConcreteTypes.cpp +++ b/gps/core/data-items/DataItemConcreteTypes.cpp @@ -485,11 +485,11 @@ void BtLeDeviceScanDetailsDataItem::stringify(string& valueStr) { valueStr += d->mApSrnRssi; valueStr += ", "; - char t[10]; - memset (t, '\0', 10); + char t[20]; + memset (t, '\0', 20); valueStr += BTLESCANDETAILS_FIELD_MAC; valueStr += ": "; - snprintf(t, 10, "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], + snprintf(t, 20, "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], d->mApSrnMacAddress[1], d->mApSrnMacAddress[2], d->mApSrnMacAddress[3], d->mApSrnMacAddress[4], d->mApSrnMacAddress[5]); valueStr += t; @@ -534,11 +534,11 @@ void BtDeviceScanDetailsDataItem::stringify(string& valueStr) { valueStr += d->mApSrnRssi; valueStr += ", "; - char t[10]; - memset (t, '\0', 10); + char t[20]; + memset (t, '\0', 20); valueStr += BTSCANDETAILS_FIELD_MAC; valueStr += ": "; - snprintf(t, 10, "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], + snprintf(t, 20, "[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0], d->mApSrnMacAddress[1], d->mApSrnMacAddress[2], d->mApSrnMacAddress[3], d->mApSrnMacAddress[4], d->mApSrnMacAddress[5]); valueStr += t;