-Wreorder-ctor is a compile-time, Clang-only flag which is enabled by
default since Clang 12, which will warn whenever a specified field will
be initialized right after field specified below it. However, since it
doesn't sweep through all fields, compiler may miss some of them.
This order has been checked thoroughly through many trial and errors to
ensure that no such warns will be triggered anymore.
Change-Id: Id24cbb7277dc8d6c02767f8f365818ab6c017683
Fixes:
gps/core/data-items/DataItemConcreteTypes.cpp:465:9: error: 'snprintf'
will always be truncated; specified size is 10, but format string
expands to at least 20 [-Werror,-Wfortify-source]
465 | snprintf(t, sizeof(t),
"[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0],
| ^
gps/core/data-items/DataItemConcreteTypes.cpp:514:9: error: 'snprintf'
will always be truncated; specified size is 10, but format string
expands to at least 20 [-Werror,-Wfortify-source]
514 | snprintf(t, sizeof(t),
"[%02x:%02x:%02x:%02x:%02x:%02x]", d->mApSrnMacAddress[0],
| ^
2 errors generated.
Change-Id: I37188e7497f7ade97648fb41e2becd73f6b559a9
