GivFNZ/my-website
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Security fixes, documentation updates, and cleanup #1

Merged
GivFNZ merged 4 commits from aidan/my-website:main into main 2025-03-27 23:01:56 +00:00
Conversation 0 Commits 4 Files Changed 8 +56 -2111
aidan commented 2025-03-27 20:56:04 +00:00
Contributor
Copy Link

I've made some small tweaks and improvements to your website, and fixed a security issue with the Last.fm API. I noticed that the Last.fm API key gets exposed to the client when fetching songs, as it's not done server-sided.

I have set the API key to null in the API, so simply merging this pull request will disable the API, with no changes to backend required. I can always help if you need help with the Last.fm API :)

Hope this helps!

Changes

Added:

  • Environment variable documentation
  • Added pnpm lock in .gitignore

Changed:

  • Last.fm API (disabled for security)
  • Updated bun lock exclude in .gitignore
  • Minor grammar changes to en-us locale (see note below about translations)
  • Documentation improvements (grammar, clarity) and linting
  • Recently played/now playing styling improvements (more spacing for easier reading)

Don't forget this

Translations from en-us -> pt-br need to be done again for these strings:

  • myLastDescription
  • lastLink
I've made some small tweaks and improvements to your website, and fixed a security issue with the Last.fm API. I noticed that the Last.fm API key gets exposed to the client when fetching songs, as it's not done server-sided. I have set the API key to `null` in the API, so simply merging this pull request will disable the API, with no changes to backend required. I can always help if you need help with the Last.fm API :) Hope this helps! --- ## Changes **Added:** - Environment variable documentation - Added pnpm lock in `.gitignore` **Changed:** - Last.fm API (disabled for security) - Updated bun lock exclude in `.gitignore` - Minor grammar changes to en-us locale (see note below about translations) - Documentation improvements (grammar, clarity) and linting - Recently played/now playing styling improvements (more spacing for easier reading) ## Don't forget this Translations from en-us -> pt-br need to be done again for these strings: - `myLastDescription` - `lastLink`
aidan added 4 commits 2025-03-27 20:56:05 +00:00
aidan requested review from GivFNZ 2025-03-27 20:56:05 +00:00
GivFNZ merged commit 314ab2983a into main 2025-03-27 23:01:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GivFNZ
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GivFNZ/my-website#1
No description provided.
Delete Branch "aidan/my-website:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?